Message-ID: <gh-pgjdbc-pgjdbc-3526-rc2058253742@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 24 Apr 2025 12:18:26 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3526: Set column name explicitely when using `current_database()` in queries
In-Reply-To: <gh-pgjdbc-pgjdbc-3526-rc2056763507@github.com>
References: <gh-pgjdbc-pgjdbc-3526@github.com> <gh-pgjdbc-pgjdbc-3526-rc2056763507@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 2058253742
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 532c217a5c7d5ee4b136873a9ad822330a761091
X-GitHub-Issue: 3526
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3526#discussion_r2058253742
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java)

In retrospect I should have removed all of those in https://github.com/pgjdbc/pgjdbc/pull/3588. By the time we get to the query we know that if the catalog is not null then it is the same as `current_database()` If you want to make those changes I'd appreciate it. Otherwise I'll make them which might make your's harder to rebase.