Message-ID: <gh-pgjdbc-pgjdbc-3528-c2772817959@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 02 Apr 2025 14:51:54 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3528: Implement performance fix for catalog check in DatabaseMetaData
In-Reply-To: <gh-pgjdbc-pgjdbc-3528@github.com>
References: <gh-pgjdbc-pgjdbc-3528@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 2772817959
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3528
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3528#issuecomment-2772817959
Content-Type: text/plain; charset=utf-8

@SophiahHo reviewing this as I understand this you are adding `and FALSE` if the catalog isn't equal to the current catalog. Why even run the SQL? We know the ResultSet is going to be empty, we could fabricate an empty ResultSet instead.