Message-ID: <gh-pgjdbc-pgjdbc-3532-rc1963459783@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 20 Feb 2025 12:14:57 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3532: Datetime-related tests improved
In-Reply-To: <gh-pgjdbc-pgjdbc-3532@github.com>
References: <gh-pgjdbc-pgjdbc-3532@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 1963459783
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 38450b85eaab5592158abe485f634468f6943dd7
X-GitHub-Issue: 3532
X-GitHub-Path: pgjdbc/src/test/java/org/postgresql/jdbc/TimeZoneTest.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3532#discussion_r1963459783
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/test/java/org/postgresql/jdbc/TimeZoneTest.java)

As you add assertions, please consider messages that would clarify the reason the assertion is there.

The current assertion would fail as `testConnection[zoneId=Europe/Paris] expected: true, got: false Client and server time are close enough`. I'm not sure it provides enough information to convey why the client and server times must match.