pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3532: Datetime-related tests improved
Date: Fri, 21 Feb 2025 10:40:24 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

(on pgjdbc/src/test/java/org/postgresql/jdbc/TimeZoneTest.java)

@seregaizsbera , if you happen to understand Russian, I would recommend watching https://www.youtube.com/watch?v=sS3S9PfUwxc which elaborates on why `assertTrue` might be harmful in many cases.

I do not mean the test fails right now. What I mean is `expected: true got: false` makes maintenance much harder.

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #3532: Datetime-related tests improved
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox