Message-ID: <gh-pgjdbc-pgjdbc-3532-rc2025084975@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 02 Apr 2025 15:28:47 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3532: Datetime-related tests improved
In-Reply-To: <gh-pgjdbc-pgjdbc-3532@github.com>
References: <gh-pgjdbc-pgjdbc-3532@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2025084975
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 38450b85eaab5592158abe485f634468f6943dd7
X-GitHub-Issue: 3532
X-GitHub-Line: 61
X-GitHub-Path: pgjdbc/src/test/java/org/postgresql/jdbc/TimeZoneTest.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3532#discussion_r2025084975
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/test/java/org/postgresql/jdbc/TimeZoneTest.java:61)

It sounds a bit strange you fetch the list of time zones with `ZoneId` and then configure the default one with `TimeZone`.

Should this better be `TimeZone.getAvailableIDs()` so we use get and set from the same class?