Message-ID: <gh-pgjdbc-pgjdbc-3533-rc1987317198@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 10 Mar 2025 13:44:35 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3533: refactor: Use key_column_usage instead of indnkeyatts in PgDatabaseMetaData for faster speed and improved compatibility
In-Reply-To: <gh-pgjdbc-pgjdbc-3533@github.com>
References: <gh-pgjdbc-pgjdbc-3533@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 1987317198
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 8c8e4fe6997bbc1c183302d9d5d5cc4a53be5c4a
X-GitHub-Issue: 3533
X-GitHub-Line: 2347
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3533#discussion_r1987317198
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java:2347)

I think you need to rebase. This code where we are selecting `current_database() as TABLE_CAT` is in HEAD