Message-ID: <gh-pgjdbc-pgjdbc-3533-rc1987439581@github.com>
From: "hlcianfagna (@hlcianfagna)" <noreply+hlcianfagna@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 10 Mar 2025 14:41:48 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3533: refactor: Use key_column_usage instead of indnkeyatts in PgDatabaseMetaData for faster speed and improved compatibility
In-Reply-To: <gh-pgjdbc-pgjdbc-3533-rc1987317198@github.com>
References: <gh-pgjdbc-pgjdbc-3533@github.com> <gh-pgjdbc-pgjdbc-3533-rc1987317198@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: hlcianfagna
X-GitHub-Comment-Id: 1987439581
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 8c8e4fe6997bbc1c183302d9d5d5cc4a53be5c4a
X-GitHub-Issue: 3533
X-GitHub-Line: 2347
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3533#discussion_r1987439581
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java:2347)

One more thing to note about this line, in the old version there was an outer query with quoted upper case identifiers and this inner query with unquoted identifiers. In the new version there are no subqueries, so I am returning quoted upper-case identifiers as was the case in the original outer query.