Message-ID: <gh-pgjdbc-pgjdbc-3561-c2708797146@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sun, 09 Mar 2025 10:56:54 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3561: remove forcing uppercase and use the function upperCaseFieldLabels instead
In-Reply-To: <gh-pgjdbc-pgjdbc-3561@github.com>
References: <gh-pgjdbc-pgjdbc-3561@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2708797146
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3561
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3561#issuecomment-2708797146
Content-Type: text/plain; charset=utf-8

Even though we might have a function that forces all the column names go uppercase, it seems wasteful to force the conversion every time as we could just spell the columns so they go uppercase in the first place.

In other words, I'm fine to keep `upperCaseFieldLabels` call. However, it looks we could make the driver more efficient if we keep the quotes so the columns go upper case on their own, and we do not spent time in `upperCaseFieldLabels`