Message-ID: <gh-pgjdbc-pgjdbc-3565-rc2023557591@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 01 Apr 2025 19:28:01 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3565: Use query to find the current catalog instead of relying on the database in the connection URL or connection properties as this could be different if connected through a pooler or proxy
In-Reply-To: <gh-pgjdbc-pgjdbc-3565@github.com>
References: <gh-pgjdbc-pgjdbc-3565@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2023557591
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 22cdd41d8097f322102d20c1474391abebdd3464
X-GitHub-Issue: 3565
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3565#discussion_r2023557591
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java)

```suggestion
  private @Nullable String catalog;
```

I guess we have `@SuppressWarning` for `PgConnection` constructor, so it results in silencing warning for the newly added field.
However, the field is nullable, so let's specify nullable type.