Message-ID: <gh-pgjdbc-pgjdbc-3588-c2785848929@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 08 Apr 2025 09:40:58 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3588: refactor empty resultset to use empty result set if the catalog is not correct
In-Reply-To: <gh-pgjdbc-pgjdbc-3588@github.com>
References: <gh-pgjdbc-pgjdbc-3588@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 2785848929
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3588
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3588#issuecomment-2785848929
Content-Type: text/plain; charset=utf-8

I did put in a check for isvalid() but looking at the rest of the code we return many functions without verifying the connection is valid.

Thoughts @vlsi @sehrope ?