pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3588: refactor empty resultset to use empty result set if the catalog is not correct
Date: Sun, 13 Apr 2025 08:49:20 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
(on pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java:1270)
`"" retrieves those without a catalog`
I assume PostgreSQL does not have "procedures without a catalog", so `catalog.isEmpty()` check looks redundant here. WDYT of replacing this with `catalog != null && (catalog.isEmpty() || !catalog.equals(connection.getCatalog()))`
`!Objects.equals(catalog, connection.getCatalog())` could do as well (at a cost of one-time SQL in `getCatalog()`)
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #3588: refactor empty resultset to use empty result set if the catalog is not correct
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox