Message-ID: <gh-pgjdbc-pgjdbc-3589-rc2035869005@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 09 Apr 2025 18:00:57 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3589: Metadata CHAR_OCTET_LENGTH is a positive number for non-character column types
In-Reply-To: <gh-pgjdbc-pgjdbc-3589@github.com>
References: <gh-pgjdbc-pgjdbc-3589@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2035869005
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 197c8210934a37454e60ecebccfeaf1468a16f0b
X-GitHub-Issue: 3589
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3589#discussion_r2035869005
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java)

Could you add `NCHAR`, `NVARCHAR`, and `LONGNVARCHAR` as well?
It might be we should add `CLOB` here as well, however, I am not sure.