Message-ID: <gh-pgjdbc-pgjdbc-3589-rc2041073622@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sun, 13 Apr 2025 08:21:21 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3589: Metadata CHAR_OCTET_LENGTH is a positive number for non-character column types
In-Reply-To: <gh-pgjdbc-pgjdbc-3589@github.com>
References: <gh-pgjdbc-pgjdbc-3589@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2041073622
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 197c8210934a37454e60ecebccfeaf1468a16f0b
X-GitHub-Issue: 3589
X-GitHub-Line: 1991
X-GitHub-Path: pgjdbc/src/test/java/org/postgresql/test/jdbc2/DatabaseMetaDataTest.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3589#discussion_r2041073622
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/DatabaseMetaDataTest.java:1991)

A tiny note: lambdas could help with lazy execution, so the test does not spend time on building the failure message in case of the passing tests.

```suggestion
      assertTrue(rs.next(), () -> "dbmd.getColumns returned no rows for column " + columnName);
```