Message-ID: <gh-pgjdbc-pgjdbc-3592-rc2041062827@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sun, 13 Apr 2025 07:09:16 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3592:  Handle protocol 3.2 and wider cancel keys. 
In-Reply-To: <gh-pgjdbc-pgjdbc-3592@github.com>
References: <gh-pgjdbc-pgjdbc-3592@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2041062827
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 4b3dc4a9751cec4747dac8261db56d31ebfe1165
X-GitHub-Issue: 3592
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/ConnectionFactory.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3592#discussion_r2041062827
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/ConnectionFactory.java)

Should we restrict the supported protocol versions only? If a newer protocol adds something in 3.7, the old existing drivers won't support 3.7 features anyway.

It looks it would be nice if the driver could reject unsupported values, so the users know the value they configure is ignored or unsupported.

WDYT?