pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3592: Handle protocol 3.2 and wider cancel keys.
Date: Sun, 13 Apr 2025 08:06:12 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
(on pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java)
WDYT of one of the following so it could return `ProtocolVersion` instance rather multiple minor/major getters?
`getProtocolVersionInfo()`
* Emphasizes that this is more than just a number now.
* Common naming pattern when moving from primitive to object.
`getProtocolVersionObject()`
* Straightforward, explicitly communicates it's an object.
`getProtocolVersionDetails()`
* Suggests there might be more metadata than just a version number.
`getProtocolVersionValue()`
* Implies it's the full value, which works if the class holds major/minor etc.
`getFullProtocolVersion()`
* Indicates a more complete version compared to the basic int.
`getProtocolVersionEx()` (or `getProtocolVersionExtended()`)
* Simple, adds the "extended" idea, though a bit more API-looking.
view thread (37+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #3592: Handle protocol 3.2 and wider cancel keys.
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox