Message-ID: <gh-pgjdbc-pgjdbc-3592-rc2041071804@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sun, 13 Apr 2025 08:10:11 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3592:  Handle protocol 3.2 and wider cancel keys. 
In-Reply-To: <gh-pgjdbc-pgjdbc-3592@github.com>
References: <gh-pgjdbc-pgjdbc-3592@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2041071804
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 4b3dc4a9751cec4747dac8261db56d31ebfe1165
X-GitHub-Issue: 3592
X-GitHub-Line: 954
X-GitHub-Path: pgjdbc/src/test/java/org/postgresql/test/jdbc2/StatementTest.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3592#discussion_r2041071804
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/StatementTest.java:954)

Does the test differ from `closeInProgressStatement`? (looks like the only difference is 3.2 in the setup, however, I can't tell if the rest is the same or not)
If the core is the same, could you factor it to a say `private` method which you call from both of the tests?

It is hard to review and maintain code with large amount of duplicate logic.