Message-ID: <gh-pgjdbc-pgjdbc-3592-rc2046769331@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 16 Apr 2025 11:57:40 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3592:  Handle protocol 3.2 and wider cancel keys. 
In-Reply-To: <gh-pgjdbc-pgjdbc-3592@github.com>
References: <gh-pgjdbc-pgjdbc-3592@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2046769331
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 4b3dc4a9751cec4747dac8261db56d31ebfe1165
X-GitHub-Issue: 3592
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/ProtocolVersion.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3592#discussion_r2046769331
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/ProtocolVersion.java)

I'm not sure `(int protocol)` constructor belongs here at it is an implementation detail of `NegotiateProtocolVersion` message. Let's remove (int) constructor, and let's make the other constructor `private`.

```suggestion
  private ProtocolVersion(int major, int minor) {
    this.major = major;
    this.minor = minor;
  }
```