Message-ID: <gh-pgjdbc-pgjdbc-3631-c2876835965@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 13 May 2025 14:48:52 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3631: fix: isValid incorrectly called execute, instead of executeWithFlags fixes Issue #3630
In-Reply-To: <gh-pgjdbc-pgjdbc-3631@github.com>
References: <gh-pgjdbc-pgjdbc-3631@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2876835965
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2025-05-13T14:49:02Z
X-GitHub-Issue: 3631
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3631#issuecomment-2876835965
Content-Type: text/plain; charset=utf-8

`javac` does have `-Xlint:cast` to detect redundant casts, however, it does not understand the cast in `((PgStatement)checkConnectionQuery).execute("", QueryExecutor.QUERY_EXECUTE_AS_SIMPLE);` is redundant.
I will file an enhancement request to `javac`.