Message-ID: <gh-pgjdbc-pgjdbc-3631-c2933560479@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 03 Jun 2025 05:45:50 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3631: fix: isValid incorrectly called execute, instead of executeWithFlags fixes Issue #3630
In-Reply-To: <gh-pgjdbc-pgjdbc-3631@github.com>
References: <gh-pgjdbc-pgjdbc-3631@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2933560479
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3631
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3631#issuecomment-2933560479
Content-Type: text/plain; charset=utf-8

`AutoRollbackTest` reproduces with the base code.
You could set a breakpoint in https://github.com/pgjdbc/pgjdbc/blob/10e3546750888767191df90f188651306b3bafa7/pgjdbc/src/test/java/org/postgresql/test/jdbc2/AutoRollbackTestSuite.java#L313-L315, and there you'll see that `.isValid(4)` executes an **extended** query.

An alternative option is to add `e.printStackTrace()` here: https://github.com/pgjdbc/pgjdbc/blob/10e3546750888767191df90f188651306b3bafa7/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java#L1568 so you could see there are "prepared statement does not exist" errors coming from `.isValid`.