pgjdbc/pgjdbc GitHub issues and pull requests (mirror)help / color / mirror / Atom feed
[pgjdbc/pgjdbc] PR #3633: fix: add validation for rectangular arrays in ArrayEncoding Closes #3567 2+ messages / 1 participants [nested] [flat]
* [pgjdbc/pgjdbc] PR #3633: fix: add validation for rectangular arrays in ArrayEncoding Closes #3567 @ 2025-05-17 08:44 "awadhesh14 (@awadhesh14)" <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: awadhesh14 (@awadhesh14) @ 2025-05-17 08:44 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> Add validation to reject jagged arrays during array creation. Previously, jagged arrays caused silent corruption in text mode or protocol errors in binary mode. Validation includes: - Recursive dimension checks for multi-dimensional arrays - Null element preservation (PostgreSQL-compatible) - Detailed error messages with array indices - Full compatibility with valid rectangular arrays Closes #3567 ### All Submissions: * [x] Have you followed the guidelines in our [Contributing](https://github.com/pgjdbc/pgjdbc/blob/master/CONTRIBUTING.md) document? * [x] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change? ### Changes to Existing Features: * [ ] Does this break existing behaviour? If so please explain. * [x] Have you added an explanation of what your changes do and why you'd like us to include them? * [x] Have you written new tests for your core changes, as applicable? * [x] Have you successfully run tests with your changes locally? ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3633: fix: add validation for rectangular arrays in ArrayEncoding Closes #3567 @ 2025-05-20 16:57 "awadhesh14 (@awadhesh14)" <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: awadhesh14 (@awadhesh14) @ 2025-05-20 16:57 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> @davecramer 1. fixed the code style according to the style guide. 2. fixed the jagged array in existing test case. All checks are passing. Please review when convenient. ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-05-20 16:57 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-05-17 08:44 [pgjdbc/pgjdbc] PR #3633: fix: add validation for rectangular arrays in ArrayEncoding Closes #3567 "awadhesh14 (@awadhesh14)" <[email protected]> 2025-05-20 16:57 Re: [pgjdbc/pgjdbc] PR #3633: fix: add validation for rectangular arrays in ArrayEncoding Closes #3567 "awadhesh14 (@awadhesh14)" <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox