pgjdbc/pgjdbc GitHub issues and pull requests (mirror)help / color / mirror / Atom feed
[pgjdbc/pgjdbc] issue #3635: Consider migrating from spaces to tabs 4+ messages / 3 participants [nested] [flat]
* [pgjdbc/pgjdbc] issue #3635: Consider migrating from spaces to tabs @ 2025-05-21 19:27 "vlsi (@vlsi)" <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: vlsi (@vlsi) @ 2025-05-21 19:27 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> See * https://www.reddit.com/r/javascript/comments/c8drjo/nobody_talks_about_the_real_reason_to_use_tabs/ >i get approached by not one, but TWO coworkers who unfortunately are highly visually impaired, and each has a different visual impairment > * one of them uses tab-width 1 because he uses such a gigantic font-size > * the other uses tab-width 8 and a really wide monitor > * these guys have serious problems using codebases with spaces, they have to convert, do their work, and then unconvert before committing > * these guys are not just being fussy — it's almost surprising they can code at all, it's kind of sad to watch but also inspiring Code with tabs consumes [fewer cells on braille displays](https://stitcher.io/blog/tabs-are-better). Code with tabs consumes the same or bigger amount of tokens when using [ChatGPT 4o tokenizer](https://platform.openai.com/tokenizer). For the small files the number of tokens is more-or-less the same, and a bigger [TrieNode.kt](https://github.com/Kotlin/kotlinx.collections.immutable/blob/bd5ac10f1e3b72c8bd6335005bf27d751e0d8b5...) consumes 8958 tokens (32462 chars) with tabs, and it consumes 8859 tokens (37757 chars) which means 1% more LLM tokens when using tabs :-/ Of course, changing the spaces to tabs would be disruptive, however, it might bearable. I've not explored it yet. However, it looks going with tabs is the right thing to do. See: * https://x.com/Rich_Harris/status/1541761871585464323 * https://github.com/prettier/prettier/issues/7475 * https://stitcher.io/blog/tabs-are-better * https://youtrack.jetbrains.com/issue/KT-77740/Consider-moving-Kotlin-style-guide-to-tabs-for-the-acc... ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgjdbc/pgjdbc] issue #3635: Consider migrating from spaces to tabs @ 2025-05-21 20:10 "davecramer (@davecramer)" <[email protected]> 2 siblings, 0 replies; 4+ messages in thread From: davecramer (@davecramer) @ 2025-05-21 20:10 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> Interesting... BTW, not sure if that is the reason but PostgreSQL uses tabs ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgjdbc/pgjdbc] issue #3635: Consider migrating from spaces to tabs @ 2025-05-22 17:55 "sehrope (@sehrope)" <[email protected]> 2 siblings, 0 replies; 4+ messages in thread From: sehrope (@sehrope) @ 2025-05-22 17:55 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> The git blame churn for this would be pretty annoying. ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgjdbc/pgjdbc] issue #3635: Consider migrating from spaces to tabs @ 2025-05-22 23:21 "vlsi (@vlsi)" <[email protected]> 2 siblings, 0 replies; 4+ messages in thread From: vlsi (@vlsi) @ 2025-05-22 23:21 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> git blame would not be impacted at all as we could add it as yet another commit to https://github.com/pgjdbc/pgjdbc/blob/master/.git-blame-ignore-revs ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-05-22 23:21 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-05-21 19:27 [pgjdbc/pgjdbc] issue #3635: Consider migrating from spaces to tabs "vlsi (@vlsi)" <[email protected]> 2025-05-21 20:10 ` "davecramer (@davecramer)" <[email protected]> 2025-05-22 17:55 ` "sehrope (@sehrope)" <[email protected]> 2025-05-22 23:21 ` "vlsi (@vlsi)" <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox