Message-ID: <gh-pgjdbc-pgjdbc-3641-c2922889253@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Fri, 30 May 2025 16:54:15 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3641: feat: use PreparedStatement for DatabaseMetaData.getCrossReference, getImportedKeys, getExportedKeys
In-Reply-To: <gh-pgjdbc-pgjdbc-3641@github.com>
References: <gh-pgjdbc-pgjdbc-3641@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2922889253
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3641
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3641#issuecomment-2922889253
Content-Type: text/plain; charset=utf-8

Any thoughts?
I think we could merge this and release yet another version to get the perf issue fixed.

The core changes here are like `String->StringBuilder`. It would be great to add `try-with-resources`, however I don't like to mix many changes into a single PR.