Message-ID: <gh-pgjdbc-pgjdbc-3652-c2929224329@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 02 Jun 2025 07:34:04 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3652: chore: update JUnit to 5.13, use @ParameterizedClass
In-Reply-To: <gh-pgjdbc-pgjdbc-3652@github.com>
References: <gh-pgjdbc-pgjdbc-3652@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2929224329
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3652
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3652#issuecomment-2929224329
Content-Type: text/plain; charset=utf-8

The procedure was like
* remove `import org.junit.Test;`
* autofix "import `@Test`" with junit5
* autofix "JUnit4 assertions used in JUnit5 test"
* make all Assertion imports static
* wrap long assertion lines if needed <-- this was manual
* replace `@RunWith(Parameterized.class)` with `@ParameterizedClass`, add `@MethodSource("data")`

My guess is that with an LLM I would not have any confidence in the result: JUnit4 and JUnit5 have different order of arguments for `assertEquals`, and sometimes the code was using the wrong order.

As I migrated the code I did not bother understanding the diffs as long as it compiled.