Message-ID: <gh-pgjdbc-pgjdbc-3657-rc2180434226@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 02 Jul 2025 15:58:50 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3657: perf: cache composite and simple subqueries
In-Reply-To: <gh-pgjdbc-pgjdbc-3657@github.com>
References: <gh-pgjdbc-pgjdbc-3657@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2180434226
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: a757e8efffb0fdeeb39e031167bb14c539e98542
X-GitHub-Issue: 3657
X-GitHub-Line: 1810
X-GitHub-Path: pgjdbc/src/test/java/org/postgresql/test/jdbc2/PreparedStatementTest.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3657#discussion_r2180434226
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/PreparedStatementTest.java:1810)

I see the rest might be using `closeQuietly`, however, it would be better to go for try-with-resources in the new code