Message-ID: <gh-pgjdbc-pgjdbc-3665-c2974780056@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 16 Jun 2025 00:08:43 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3665: test: add channelBinding to SslTest
In-Reply-To: <gh-pgjdbc-pgjdbc-3665@github.com>
References: <gh-pgjdbc-pgjdbc-3665@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 2974780056
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3665
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3665#issuecomment-2974780056
Content-Type: text/plain; charset=utf-8

> If you're going to refactor the channel binding options being passed into the ScramAuthenticator then do that in its own commit. Ideally in its own PR so that we see it run through the existing tests without changing anything. Definitely don't do it in a single commit labeled "add channelBinding to ssltest" as it's not test related.

I don't see where it is changing the options.
> 
> Separately, that SSLTest is too complicated as it is and I don't like adding even more to it. It also makes it annoying to test one slice of functionality (e.g., channel_binding related stuff) as it's one giant test that must be run all of nothing.
I do agree with this.
.