Message-ID: <gh-pgjdbc-pgjdbc-3694-c3017997224@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 30 Jun 2025 06:48:06 +0000
Subject: Re: [pgjdbc/pgjdbc] issue #3694: Enable reWriteBatchedInserts by default
In-Reply-To: <gh-pgjdbc-pgjdbc-3694@github.com>
References: <gh-pgjdbc-pgjdbc-3694@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 3017997224
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3694
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/issues/3694#issuecomment-3017997224
Content-Type: text/plain; charset=utf-8

>from the JDBC API user's point of view, this change does not seem to be breaking

The setting changes the behaviour of `java.sql.Statement#executeBatch`. The method should return then number of modified rows for every batched statement: `int[]`.

If the driver goes with `reWriteBatchedInserts=true`, then it can no longer tell the number of modified rows for every `addBatch` statement, so the driver has to result to `Statement.SUCCESS_NO_INFO` value.

That is why we can't flip the default.