Message-ID: <gh-pgjdbc-pgjdbc-3698-rc2183134948@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 03 Jul 2025 15:47:27 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3698: fix: updateStatus message to microseconds since midnight 01-01-1970 instead of using nanotime
In-Reply-To: <gh-pgjdbc-pgjdbc-3698-rc2182022181@github.com>
References: <gh-pgjdbc-pgjdbc-3698@github.com> <gh-pgjdbc-pgjdbc-3698-rc2182022181@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2183134948
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 0ddeeab6b47eb39416a49b3546f8647e159f6869
X-GitHub-Issue: 3698
X-GitHub-Line: 222
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/replication/V3PGReplicationStream.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3698#discussion_r2183134948
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/replication/V3PGReplicationStream.java:222)

No no no. I do not suggest adding abs. I just mean that it is often the case for a `+` vs `-` or `between(POSTGRES_EPOCH_2000_01_01, now)` vs `between(now, POSTGRES_EPOCH_2000_01_01)` errors. Sure one of them is right, and I just wonder how can we be sure the code is right here.