Message-ID: <gh-pgjdbc-pgjdbc-3700-rc2178529594@github.com>
From: "harinath001 (@harinath001)" <noreply+harinath001@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 01 Jul 2025 21:11:17 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3700: Add PEMKeyManager to handle PEM based certs and keys.
In-Reply-To: <gh-pgjdbc-pgjdbc-3700-rc2178331799@github.com>
References: <gh-pgjdbc-pgjdbc-3700@github.com> <gh-pgjdbc-pgjdbc-3700-rc2178331799@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: harinath001
X-GitHub-Comment-Id: 2178529594
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 4c48827d92842b518dc418788cea5b0a71c477ba
X-GitHub-Issue: 3700
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/ssl/LibPQFactory.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3700#discussion_r2178529594
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/ssl/LibPQFactory.java)

initially I didn't have this, but one of the checks in  PRB started failing (My local setup gradle build was fine).
Hence I had to add this line.

Probably I can make the `algorithm` in PEMKeyManager constructor as nullable, but I didn't prefer it.

So, i believe adding this line is kind of necessary because `getOrDefault` returns nullable.