Message-ID: <gh-pgjdbc-pgjdbc-3700-rc2178544302@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 01 Jul 2025 21:18:30 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3700: Add PEMKeyManager to handle PEM based certs and keys.
In-Reply-To: <gh-pgjdbc-pgjdbc-3700-rc2178331799@github.com>
References: <gh-pgjdbc-pgjdbc-3700@github.com> <gh-pgjdbc-pgjdbc-3700-rc2178331799@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 2178544302
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 4c48827d92842b518dc418788cea5b0a71c477ba
X-GitHub-Issue: 3700
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/ssl/LibPQFactory.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3700#discussion_r2178544302
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/ssl/LibPQFactory.java)

I presume it failed because it was returning an @Nullable you can cast it to notNull to fix it. You set a default in PEM_KEY_ALGORITHM so it will not return null