Message-ID: <gh-pgjdbc-pgjdbc-3700-rc2491618666@github.com>
From: "harinath001 (@harinath001)" <noreply+harinath001@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 04 Nov 2025 18:13:56 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3700: Add PEMKeyManager to handle PEM based certs and keys.
In-Reply-To: <gh-pgjdbc-pgjdbc-3700-rc2487830236@github.com>
References: <gh-pgjdbc-pgjdbc-3700@github.com> <gh-pgjdbc-pgjdbc-3700-rc2487830236@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: harinath001
X-GitHub-Comment-Id: 2491618666
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 4c48827d92842b518dc418788cea5b0a71c477ba
X-GitHub-Issue: 3700
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/ssl/PEMKeyManager.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3700#discussion_r2491618666
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/ssl/PEMKeyManager.java)

@davecramer I have added new code for checking the file permissions (had to handle posix + windows) but wondering if this kind of checks already happening in other places ? Would like to reuse it if possible. Thanks.