Message-ID: <gh-pgjdbc-pgjdbc-3705-c3178173547@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 12 Aug 2025 07:58:33 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3705: feat: default query timeout property
In-Reply-To: <gh-pgjdbc-pgjdbc-3705@github.com>
References: <gh-pgjdbc-pgjdbc-3705@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 3178173547
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3705
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3705#issuecomment-3178173547
Content-Type: text/plain; charset=utf-8

I've made a second review pass, and I wondered whether we should support millisecond resolution for the default query timeout or second resolution.

JDBC supports second-resolution only via `java.sql.Statement#setQueryTimeout(int seconds)`.
At the same time, `java.sql.Connection#setNetworkTimeout(Executor, int millis)` uses millis.

pgjdbc has `org.postgresql.jdbc.PgStatement#setQueryTimeoutMs(long millis)` which uses millis.

However, the existing `loginTimeout`, `connectTimeout`, `socketTimeout`, and `cancelSignalTimeout` connection properties use seconds. So it sounds fine to use seconds unit for the newly added `defaultQueryTimeout` property.