Message-ID: <gh-pgjdbc-pgjdbc-3705-c3179425895@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 12 Aug 2025 13:48:11 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3705: feat: default query timeout property
In-Reply-To: <gh-pgjdbc-pgjdbc-3705@github.com>
References: <gh-pgjdbc-pgjdbc-3705@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 3179425895
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3705
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3705#issuecomment-3179425895
Content-Type: text/plain; charset=utf-8

It is a new connection property so the users could configure "global query timeout" for their connection pools. It is somewhat related to `socketTimeout`.

At the same time, when it comes to naming, it looks like we don't use `default...` prefix often (the only property is `defaultRowFetchSize`).
It might be a good idea to go for `queryTimeout` naming, so it becomes the same property at different levels:
* connection pool level via "`queryTimeout` connection property"
* `java.sql.Connection` level via `PGConnection#setQueryTimeout(int)` (I'm not sure it exists now)
* `java.sql.Statement` level via `Statement#setQueryTimeout(int)`