pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feed[pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
15+ messages / 6 participants
[nested] [flat]
* [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2025-07-17 13:28 "vlsi (@vlsi)" <[email protected]>
0 siblings, 0 replies; 15+ messages in thread
From: vlsi (@vlsi) @ 2025-07-17 13:28 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Fixes https://github.com/pgjdbc/pgjdbc/issues/3107
TODO:
- [ ] Add test to reproduce the failure
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2025-07-19 16:15 ` "vlsi (@vlsi)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: vlsi (@vlsi) @ 2025-07-19 16:15 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
@papegaaij, do you think you could try this change with pgpool2?
Frankly, I do not see a clear way of testing the change without pgpool2, and it looks like adding pgpool2 to the tests would take some time.
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2025-07-20 05:21 ` "papegaaij (@papegaaij)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: papegaaij (@papegaaij) @ 2025-07-20 05:21 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Thanks for the work on this issue! I'm currently on vacation, but I'll ask a colleague to test this. Keep in mind though that we were only able to reproduce the original issue consistently in production. On our testing environment we will need to run with the patched version for several weeks before we can say with any certainty the problem is fixed.
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2025-07-23 07:32 ` "haster (@haster)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: haster (@haster) @ 2025-07-23 07:32 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
I've built pgjdbc based on this pull request and deployed it to our test environment. As @papegaaij said, due to the low amount of traffic on that environment we would need to run with this for a couple of weeks to be able to say the problem is fixed with any certainty, but testing is underway :muscle:
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2025-08-04 11:25 ` "haster (@haster)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: haster (@haster) @ 2025-08-04 11:25 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Hey, due to an error on my end we unfortunately ran with the incorrect driver for our first week of testing, but the 'good' news is that I quickly noticed that while checking the logs. After fixing that last tuesday we now run with the correct (patched) driver and I haven't seen this error reoccur so far.
We still need to wait longer to be more sure, since it is a testing environment with nowhere near production-like usage patterns, but things are looking good on our end.
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2025-08-04 11:29 ` "vlsi (@vlsi)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: vlsi (@vlsi) @ 2025-08-04 11:29 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
@haster , thanks so much for testing this, and it is really painful for me to test in prod what could be tested in CI. One of the options that might be useful is to configure pgpool2 and make tests work through pgool2 -> test database.
Frankly speaking, I have previously tried adding pgpool2 to our [docker-compose.yml](https://github.com/pgjdbc/pgjdbc/blob/9370b33fcce0f5605ccad500e7de9f4bf939e085/docker/postgres-serve...), however, it was harder than I thought it would be. Do you think you could help with adding pgpool2 to `docker-compose.yml`? I expect it might be fine to use it for a subset of the tests only, however, it would be nice to add those types of tests as well.
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2025-08-11 11:36 ` "haster (@haster)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: haster (@haster) @ 2025-08-11 11:36 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Hey @vlsi , we now have two weeks of testing this PR on our testing environment. So far we haven't seen the error again. As far as we are concerned this PR solves the issue :+1: Thanks for your hard work.
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2025-08-11 11:44 ` "haster (@haster)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: haster (@haster) @ 2025-08-11 11:44 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
As to your question about pgpool in the docker compose, we build our own postgres and pgpool so I'm not sure how our experience translates to your situation.
Our docker-compose.yml looks something like the following:
```yaml
services:
db:
container_name: "db"
image: ...
env_file: db.env
networks:
network:
ipv4_address: << db_ip >>
read_only: True
tmpfs:
- /run:rw,noexec,nosuid,size=64k
volumes:
- /data/db:/var/lib/postgresql/data
- /var/log/db:/var/log/postgresql
tkh-pgpool:
container_name: "pgpool"
image: ...
depends_on:
- db
env_file: db.env
networks:
network:
ipv4_address: << pgpool_ip >>
read_only: True
tmpfs:
- /run/postgresql:rw,noexec,nosuid,size=64k,uid=208,gid=208
- /tmp:rw,noexec,nosuid,size=64k
volumes:
- /data/pgpool:/etc/pgpool2:ro
```
The db.env file holds nothing special, postgres user credentials and such.
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2025-08-21 14:26 ` "haster (@haster)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: haster (@haster) @ 2025-08-21 14:26 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
I just checked again and haven't found any errors since the last time I checked, so it seem to really be gone. :+1:
We'll be using the patched version in production soon. Hopefully the next official version of the driver will include this patch so we can switch back again :)
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2025-12-03 06:27 ` "bathinamahesh (@bathinamahesh)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: bathinamahesh (@bathinamahesh) @ 2025-12-03 06:27 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Hey @vlsi @haster , thanks again for all the work on this fix. Since we're integrating pgpool2 into our product, this patch is important for us. Do you happen to know when this might be merged or included in an official pgjdbc release? We really appreciate your efforts.
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2026-02-19 09:22 ` "papegaaij (@papegaaij)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: papegaaij (@papegaaij) @ 2026-02-19 09:22 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
@vlsi can you give an update on this branch? We've been running a custom patched version of pgjdbc with this change for months now, with no issues.
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2026-02-19 10:00 ` "vlsi (@vlsi)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: vlsi (@vlsi) @ 2026-02-19 10:00 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Apparently I missed merging the branch, and I missed adding a test (add pgpool2 and run the tests through pgpool2 somehow).
@davecramer , WDYT of merging this without adding a test?
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2026-02-19 11:25 ` "davecramer (@davecramer)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: davecramer (@davecramer) @ 2026-02-19 11:25 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
@vlsi fine by me
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2026-02-24 11:58 ` "davecramer (@davecramer)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: davecramer (@davecramer) @ 2026-02-24 11:58 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
@vlsi I guess we should merge this. I'm a little concerned about what it might break though.
Should we release this under a major revision change ?
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message
@ 2026-03-10 07:16 ` "sazonov (@sazonov)" <[email protected]>
13 siblings, 0 replies; 15+ messages in thread
From: sazonov (@sazonov) @ 2026-03-10 07:16 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Hello. Are there any updates on this? :)
^ permalink raw reply [nested|flat] 15+ messages in thread
end of thread, other threads:[~2026-03-10 07:16 UTC | newest]
Thread overview: 15+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-07-17 13:28 [pgjdbc/pgjdbc] PR #3728: fix: ensure extended protocol messages end with Sync message "vlsi (@vlsi)" <[email protected]>
2025-07-19 16:15 ` "vlsi (@vlsi)" <[email protected]>
2025-07-20 05:21 ` "papegaaij (@papegaaij)" <[email protected]>
2025-07-23 07:32 ` "haster (@haster)" <[email protected]>
2025-08-04 11:25 ` "haster (@haster)" <[email protected]>
2025-08-04 11:29 ` "vlsi (@vlsi)" <[email protected]>
2025-08-11 11:36 ` "haster (@haster)" <[email protected]>
2025-08-11 11:44 ` "haster (@haster)" <[email protected]>
2025-08-21 14:26 ` "haster (@haster)" <[email protected]>
2025-12-03 06:27 ` "bathinamahesh (@bathinamahesh)" <[email protected]>
2026-02-19 09:22 ` "papegaaij (@papegaaij)" <[email protected]>
2026-02-19 10:00 ` "vlsi (@vlsi)" <[email protected]>
2026-02-19 11:25 ` "davecramer (@davecramer)" <[email protected]>
2026-02-24 11:58 ` "davecramer (@davecramer)" <[email protected]>
2026-03-10 07:16 ` "sazonov (@sazonov)" <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox