Message-ID: <gh-pgjdbc-pgjdbc-3748-c3135000893@github.com>
From: "eitch (@eitch)" <noreply+eitch@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 30 Jul 2025 06:22:34 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3748: Fix #3747: Incorrect class comparison in PGXmlFactoryFactory validation
In-Reply-To: <gh-pgjdbc-pgjdbc-3748@github.com>
References: <gh-pgjdbc-pgjdbc-3748@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: eitch
X-GitHub-Comment-Id: 3135000893
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3748
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3748#issuecomment-3135000893
Content-Type: text/plain; charset=utf-8

Yeah, sorry, that was why this was still a draft. I had to find time to figure out the building and everything. It wasn't straightforward to get it to work in IntelliJ. And it doesn't build with Java 24...

Added a test now, looks fine to me.