pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3750: Use `BufferedInputStream` with `FileInputStream`
Date: Tue, 05 Aug 2025 07:31:54 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

For reference, it looks like `Files.newInputStream` could be the way to go (it does not seem to require `BufferedInputStream`), however, it does not seem to be good enough for Java 8.

See:
* https://github.com/jetty/jetty.project/issues/3840
* https://bugs.openjdk.org/browse/JDK-8227080 (fs) Files.newInputStream(...).skip(n) is slow. It is fixed in Java 14 and back-ported to Java 11.

At the same time, `Files.newInputStream` says "the stream will not be buffered", so it would require buffering anyways. 

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #3750: Use `BufferedInputStream` with `FileInputStream`
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox