Message-ID: <gh-pgjdbc-pgjdbc-3762-c3196258672@github.com>
From: "simon-greatrix (@simon-greatrix)" <noreply+simon-greatrix@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 18 Aug 2025 11:27:12 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3762: Fix: BaseDataSource.getProperty mirrors BaseDataSource.setProperty.
In-Reply-To: <gh-pgjdbc-pgjdbc-3762@github.com>
References: <gh-pgjdbc-pgjdbc-3762@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: simon-greatrix
X-GitHub-Comment-Id: 3196258672
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 3762
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3762#issuecomment-3196258672
Content-Type: text/plain; charset=utf-8

In writing a unit test I have discovered a related issue:

PGSimpleDataSource dataSource = new PGSimpleDataSource();
dataSource.setLoadBalanceHosts(false);
assertFalse( dataSource.getLoadBalanceHosts() );
The getLoadBalanceHosts() method returns true if any value is set, even if the value is false.

Should we create a new issue for this or expand the scope of this one to cover it?