pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feed[pgjdbc/pgjdbc] PR #3774: fix: Change "PST" timezone in TimestampTest to "Pacific Standard Time"
6+ messages / 3 participants
[nested] [flat]
* [pgjdbc/pgjdbc] PR #3774: fix: Change "PST" timezone in TimestampTest to "Pacific Standard Time"
@ 2025-08-19 08:54 "simon-greatrix (@simon-greatrix)" <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: simon-greatrix (@simon-greatrix) @ 2025-08-19 08:54 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
The timestamp specifier "PST" can be misinterpreted as "Philippine Standard Time" causing the test to fail if Java selects it. Use an unambiguous timezone specifier to ensure desired behaviour.
No breaking changes.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3774: fix: Change "PST" timezone in TimestampTest to "Pacific Standard Time"
@ 2025-08-19 09:13 "davecramer (@davecramer)" <[email protected]>
4 siblings, 0 replies; 6+ messages in thread
From: davecramer (@davecramer) @ 2025-08-19 09:13 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
> Looks like there was no explicit intention to test specifically for `PST`, so going for a less ambiguous code looks nice
one would think, however if fails all of the tests.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3774: fix: Change "PST" timezone in TimestampTest to "Pacific Standard Time"
@ 2025-08-19 09:13 "vlsi (@vlsi)" <[email protected]>
4 siblings, 0 replies; 6+ messages in thread
From: vlsi (@vlsi) @ 2025-08-19 09:13 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
The tests seem to fail with `Unparseable date: "1950-02-07 15:00:00 Pacific Standard Time"`.
Could you please have a look?
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3774: fix: Change "PST" timezone in TimestampTest to "Pacific Standard Time"
@ 2025-08-19 09:21 "davecramer (@davecramer)" <[email protected]>
4 siblings, 0 replies; 6+ messages in thread
From: davecramer (@davecramer) @ 2025-08-19 09:21 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
> The tests seem to fail with `Unparseable date: "1950-02-07 15:00:00 Pacific Standard Time"`. Could you please have a look?
My guess is that `Pacific Standard Time` did not exist in 1950
Alternatively we could use GMT offsets ?
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3774: fix: Change "PST" timezone in TimestampTest to "Pacific Standard Time"
@ 2025-08-19 09:25 "davecramer (@davecramer)" <[email protected]>
4 siblings, 0 replies; 6+ messages in thread
From: davecramer (@davecramer) @ 2025-08-19 09:25 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
chatgpt https://chatgpt.com/share/68a442c0-9c80-8007-b541-e2f4be77fa36
GMT offset seems the most robust
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3774: fix: Change "PST" timezone in TimestampTest to "Pacific Standard Time"
@ 2025-08-19 14:59 "simon-greatrix (@simon-greatrix)" <[email protected]>
4 siblings, 0 replies; 6+ messages in thread
From: simon-greatrix (@simon-greatrix) @ 2025-08-19 14:59 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
This is one of those "it works on my machine" issues. My machine fails with the "PST" timestamp and works with the "Pacific Standard Time".
Rather than debugging further - I agree that the spirit of the test is to do some timezone other than UTC. We do not care about how Java parses dates, so replacing PST with "GMT-08:00" should work for everyone.
I have made that change in my fork.
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-08-19 14:59 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-08-19 08:54 [pgjdbc/pgjdbc] PR #3774: fix: Change "PST" timezone in TimestampTest to "Pacific Standard Time" "simon-greatrix (@simon-greatrix)" <[email protected]>
2025-08-19 09:13 ` "davecramer (@davecramer)" <[email protected]>
2025-08-19 09:13 ` "vlsi (@vlsi)" <[email protected]>
2025-08-19 09:21 ` "davecramer (@davecramer)" <[email protected]>
2025-08-19 09:25 ` "davecramer (@davecramer)" <[email protected]>
2025-08-19 14:59 ` "simon-greatrix (@simon-greatrix)" <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox