pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

[pgjdbc/pgjdbc] PR #3802: fix: Update release plugin config to use .set(...) for props and inject nexus secrets via props
8+ messages / 3 participants
[nested] [flat]

* [pgjdbc/pgjdbc] PR #3802: fix: Update release plugin config to use .set(...) for props and inject nexus secrets via props
@ 2025-09-18 19:06 "sehrope (@sehrope)" <[email protected]>
  0 siblings, 0 replies; 8+ messages in thread

From: sehrope (@sehrope) @ 2025-09-18 19:06 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

@davecramer Eyeball this one and I guess let's try it out.

^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3802: fix: Update release plugin config to use .set(...) for props and inject nexus secrets via props
@ 2025-09-18 19:08 ` "vlsi (@vlsi)" <[email protected]>
  6 siblings, 0 replies; 8+ messages in thread

From: vlsi (@vlsi) @ 2025-09-18 19:08 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Could you please clarify the reason for the change?

^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3802: fix: Update release plugin config to use .set(...) for props and inject nexus secrets via props
@ 2025-09-18 19:09 ` "vlsi (@vlsi)" <[email protected]>
  6 siblings, 0 replies; 8+ messages in thread

From: vlsi (@vlsi) @ 2025-09-18 19:09 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

(on build-logic/root-build/src/main/kotlin/build-logic.root-build.gradle.kts:17)

Just wondering, why replacing `=` with `.set`?

^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3802: fix: Update release plugin config to use .set(...) for props and inject nexus secrets via props
@ 2025-09-18 19:09 ` "sehrope (@sehrope)" <[email protected]>
  6 siblings, 0 replies; 8+ messages in thread

From: sehrope (@sehrope) @ 2025-09-18 19:09 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Hopefully to fix releasing to actually work: https://github.com/pgjdbc/pgjdbc/actions/runs/17837108128

Unless you think it's something else that's causing it. The error in that run is complaining that the username is not populated.

^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3802: fix: Update release plugin config to use .set(...) for props and inject nexus secrets via props
@ 2025-09-18 19:10 ` "davecramer (@davecramer)" <[email protected]>
  6 siblings, 0 replies; 8+ messages in thread

From: davecramer (@davecramer) @ 2025-09-18 19:10 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

(on build-logic/root-build/src/main/kotlin/build-logic.root-build.gradle.kts:17)

well as you can see from the failed release, whatever we have now doesn't work

^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3802: fix: Update release plugin config to use .set(...) for props and inject nexus secrets via props
@ 2025-09-18 19:21 ` "sehrope (@sehrope)" <[email protected]>
  6 siblings, 0 replies; 8+ messages in thread

From: sehrope (@sehrope) @ 2025-09-18 19:21 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

@vlsi Are you going to fix the release workflow or have an alternative idea as to what's wrong? If so, let us know, otherwise going to proceed with this in a few minutes to try it out.

^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3802: fix: Update release plugin config to use .set(...) for props and inject nexus secrets via props
@ 2025-09-18 19:49 ` "vlsi (@vlsi)" <[email protected]>
  6 siblings, 0 replies; 8+ messages in thread

From: vlsi (@vlsi) @ 2025-09-18 19:49 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Exactly the same code works for me in a different project: https://github.com/Netcracker/qubership-profiler-agent/blob/c71efd9d52f6d61ddc608d1a46ea9437fa04e3b8...

I don't see reasons to go for properties and so on. So I wonder why do you suggest the changes

^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3802: fix: Update release plugin config to use .set(...) for props and inject nexus secrets via props
@ 2025-09-18 19:56 ` "vlsi (@vlsi)" <[email protected]>
  6 siblings, 0 replies; 8+ messages in thread

From: vlsi (@vlsi) @ 2025-09-18 19:56 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Note: you can debug release workflows in your fork repository, so you don't need to merge fixes just to test them.

^ permalink  raw  reply  [nested|flat] 8+ messages in thread

end of thread, other threads:[~2025-09-18 19:56 UTC | newest]

Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-09-18 19:06 [pgjdbc/pgjdbc] PR #3802: fix: Update release plugin config to use .set(...) for props and inject nexus secrets via props "sehrope (@sehrope)" <[email protected]>
2025-09-18 19:08 ` "vlsi (@vlsi)" <[email protected]>
2025-09-18 19:09 ` "vlsi (@vlsi)" <[email protected]>
2025-09-18 19:09 ` "sehrope (@sehrope)" <[email protected]>
2025-09-18 19:10 ` "davecramer (@davecramer)" <[email protected]>
2025-09-18 19:21 ` "sehrope (@sehrope)" <[email protected]>
2025-09-18 19:49 ` "vlsi (@vlsi)" <[email protected]>
2025-09-18 19:56 ` "vlsi (@vlsi)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox