Message-ID: <gh-pgjdbc-pgjdbc-3835-c3460652263@github.com>
From: "Sanne (@Sanne)" <noreply+Sanne@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 29 Oct 2025 09:53:10 +0000
Subject: Re: [pgjdbc/pgjdbc] issue #3835: Virtual Thread pinned in PostgreSQL JDBC Driver 42.7.8
In-Reply-To: <gh-pgjdbc-pgjdbc-3835@github.com>
References: <gh-pgjdbc-pgjdbc-3835@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: Sanne
X-GitHub-Comment-Id: 3460652263
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2025-10-29T10:00:37Z
X-GitHub-Issue: 3835
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/issues/3835#issuecomment-3460652263
Content-Type: text/plain; charset=utf-8

hi @vlsi , I was looking into this issue as well. I agree with your assesment and I'm looking forward to more details from @mschorsch .

However as I was looking into the code, just out of curiosity - I'm wondering: why are methods `getStandardConformingStrings` and `setStandardConformingStrings` using such a lock rather than a simple volatile boolean?

Specifically:

https://github.com/pgjdbc/pgjdbc/blob/d1ddc0f0c2895abf8d87a845c8940463ea8c594e/pgjdbc/src/main/java/org/postgresql/core/QueryExecutorBase.java#L61-L62

https://github.com/pgjdbc/pgjdbc/blob/d1ddc0f0c2895abf8d87a845c8940463ea8c594e/pgjdbc/src/main/java/org/postgresql/core/QueryExecutorBase.java#L294-L305

(there seem to be no other uses of field `standardConformingStrings` )