pgjdbc/pgjdbc GitHub issues and pull requests (mirror)help / color / mirror / Atom feed
[pgjdbc/pgjdbc] PR #3838: fix: Issue #3784 pgjdbc can't decode numeric arrays containing special numbers like NaN 9+ messages / 3 participants [nested] [flat]
* [pgjdbc/pgjdbc] PR #3838: fix: Issue #3784 pgjdbc can't decode numeric arrays containing special numbers like NaN @ 2025-10-13 06:23 "ShenFeng312 (@ShenFeng312)" <[email protected]> 0 siblings, 0 replies; 9+ messages in thread From: ShenFeng312 (@ShenFeng312) @ 2025-10-13 06:23 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> fix #3784 ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3838: fix: Issue #3784 pgjdbc can't decode numeric arrays containing special numbers like NaN @ 2025-10-23 05:22 ` "ShenFeng312 (@ShenFeng312)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: ShenFeng312 (@ShenFeng312) @ 2025-10-23 05:22 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> cc @davecramer ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3838: fix: Issue #3784 pgjdbc can't decode numeric arrays containing special numbers like NaN @ 2025-10-31 08:37 ` "ShenFeng312 (@ShenFeng312)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: ShenFeng312 (@ShenFeng312) @ 2025-10-31 08:37 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> ping @davecramer ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3838: fix: Issue #3784 pgjdbc can't decode numeric arrays containing special numbers like NaN @ 2025-11-01 01:55 ` "bokken (@bokken)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: bokken (@bokken) @ 2025-11-01 01:55 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/main/java/org/postgresql/jdbc/ArrayDecoding.java:316) This change seems non-passive. Am I missing something? ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3838: fix: Issue #3784 pgjdbc can't decode numeric arrays containing special numbers like NaN @ 2025-11-01 01:57 ` "bokken (@bokken)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: bokken (@bokken) @ 2025-11-01 01:57 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/test/java/org/postgresql/test/jdbc2/ArrayTest.java:118) This does seem non passive. ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3838: fix: Issue #3784 pgjdbc can't decode numeric arrays containing special numbers like NaN @ 2025-11-01 09:51 ` "davecramer (@davecramer)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: davecramer (@davecramer) @ 2025-11-01 09:51 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/test/java/org/postgresql/test/jdbc2/ArrayTest.java:118) Well there's no other way to represent NaN. It does pass all of our tests, Do you want to revert this ? ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3838: fix: Issue #3784 pgjdbc can't decode numeric arrays containing special numbers like NaN @ 2025-11-01 13:58 ` "bokken (@bokken)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: bokken (@bokken) @ 2025-11-01 13:58 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/test/java/org/postgresql/test/jdbc2/ArrayTest.java:118) It passes the tests after changing them. The existing (unchanged) tests failed with a class cast exception. I think it does need to be reverted. We have discussed the lack of support for these special values in the past. It has been longstanding. There are not great options. 1 would be a config for how to support/map numeric arrays. 2 would be to dynamically adjust the array type based on presence of these special values ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3838: fix: Issue #3784 pgjdbc can't decode numeric arrays containing special numbers like NaN @ 2025-12-08 06:18 ` "ShenFeng312 (@ShenFeng312)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: ShenFeng312 (@ShenFeng312) @ 2025-12-08 06:18 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/test/java/org/postgresql/test/jdbc2/ArrayTest.java:118) @bokken Hello, I have resubmitted the PR according to your instructions. Could you please help me review it #3888 ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3838: fix: Issue #3784 pgjdbc can't decode numeric arrays containing special numbers like NaN @ 2025-12-08 06:19 ` "ShenFeng312 (@ShenFeng312)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: ShenFeng312 (@ShenFeng312) @ 2025-12-08 06:19 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> @bokken Hello, I have resubmitted the PR according to your instructions. Could you please help me review it #3888 ^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2025-12-08 06:19 UTC | newest] Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-10-13 06:23 [pgjdbc/pgjdbc] PR #3838: fix: Issue #3784 pgjdbc can't decode numeric arrays containing special numbers like NaN "ShenFeng312 (@ShenFeng312)" <[email protected]> 2025-10-23 05:22 ` "ShenFeng312 (@ShenFeng312)" <[email protected]> 2025-10-31 08:37 ` "ShenFeng312 (@ShenFeng312)" <[email protected]> 2025-11-01 01:55 ` "bokken (@bokken)" <[email protected]> 2025-11-01 01:57 ` "bokken (@bokken)" <[email protected]> 2025-11-01 09:51 ` "davecramer (@davecramer)" <[email protected]> 2025-11-01 13:58 ` "bokken (@bokken)" <[email protected]> 2025-12-08 06:18 ` "ShenFeng312 (@ShenFeng312)" <[email protected]> 2025-12-08 06:19 ` "ShenFeng312 (@ShenFeng312)" <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox