Message-ID: From: "devs-lair (@devs-lair)" To: "pgjdbc/pgjdbc" Date: Sat, 25 Oct 2025 08:53:28 +0000 Subject: [pgjdbc/pgjdbc] PR #3848: Fix updateRow() with OffsetTime and OffsetDataTime objects List-Id: X-GitHub-Author-Id: 196291034 X-GitHub-Author-Login: devs-lair X-GitHub-Issue: 3848 X-GitHub-Repo: pgjdbc/pgjdbc X-GitHub-State: open X-GitHub-Type: pull_request X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3848 Content-Type: text/plain; charset=utf-8 The documentation states that OffsetDateTime and OffsetTime must be used to work with time zone columns. TTIMETZ honestly stores the time zone. You can use the getObject(int, OffsetDataTime.class) method to obtain an OffsetDataTime class object, and everything works correctly. If you try to update a row with an object of this class (we update what we get), you'll get a ClassCastException. The SQL (UPDATE ...) query itself executes without error, and the data in the database itself is updated correctly. The error is specifically within PGResultSet. ### All Submissions: * [x] Have you followed the guidelines in our [Contributing](https://github.com/pgjdbc/pgjdbc/blob/master/CONTRIBUTING.md) document? * [x] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change? ### New Feature Submissions: 1. [ ] Does your submission pass tests? 2. [x] Does `./gradlew styleCheck` pass ? 3. [ ] Have you added your new test classes to an existing test suite in alphabetical order? ### Changes to Existing Features: * [ ] Does this break existing behaviour? If so please explain. * [x] Have you added an explanation of what your changes do and why you'd like us to include them? * [x] Have you written new tests for your core changes, as applicable? * [x] Have you successfully run tests with your changes locally?