Message-ID: <gh-pgjdbc-pgjdbc-3850-rc2494431340@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 05 Nov 2025 13:14:23 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3850: Comment and simplify the complex state machine logic in QueryExecutorImpl
In-Reply-To: <gh-pgjdbc-pgjdbc-3850@github.com>
References: <gh-pgjdbc-pgjdbc-3850@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2494431340
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: af15a522d453a42ecb741b50072abb2eaf9aca6d
X-GitHub-Issue: 3850
X-GitHub-Line: 507
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3850#discussion_r2494431340
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java:507)

Previously there was a code comment:

```
// If query has no resulting fields, it cannot fail with 'cached plan must not change result type'
// thus no need to set a savepoint before such query
```

I think it makes sense keeping it, otherwise it is unclear why `getFields` implies `query might fail`.