pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3870: feat: Add INFO log when fetchSize is ignored under autocommit=true
Date: Tue, 25 Nov 2025 12:46:12 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

I am afraid it might result in logging lots of extra log messages (the code would generate a message for every execution), and it will be useless if the query produces just a few rows. It would be false positives.

In the meantime, what do you think of the following instead?
a) Add a custom property for tracking performance or stability-related issues. For instance `stabilityIssues=ignore|warn|fail`. Then pgjdbc would either ignore (the default), or log a warning (`warn`), or throw an exception so the user knows which exact functionality uses a bad code pattern

b) Log a warning (~`INFO`) only in case the number of fetched rows exceeds certain threshold. It would reduce the number of false-positives. I don't like hard-coding the thresholds though.

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #3870: feat: Add INFO log when fetchSize is ignored under autocommit=true
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox