pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: davecramer (@davecramer) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3895: implement require_auth, this is pretty much how libpq does this.
Date: Tue, 24 Feb 2026 16:27:32 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
> I'm able to reproduce this error locally and tracked it down with git bisect:
>
> ```
> 3fab588d93ae4cfeb13f75ba08894b804b256d51 is the first bad commit
> commit 3fab588d93ae4cfeb13f75ba08894b804b256d51
> Author: Vladimir Sitnikov <[email protected]>
> Date: Mon Jan 19 12:16:57 2026 +0300
>
> test: add autosave=always|never|conservative and cleanupSavepoints=true|false to the randomized CI jobs
>
> :040000 040000 f663e7608969c1d7de2dbcc4df3bf8003a51c112 a2ace7b120c0c1e16f7640077410ce511aec429d M .github
> :040000 040000 93916651a74db1749db76dba81068287f9c87e0a c44dce9d078a5385473e9eccf9143057f0f38937 M build-logic
> :040000 040000 d1201b2777e25f2e89f51c6729e97511fb352e02 fa625fdb5b472f40550997b24dd625da8d265b09 M pgjdbc
> bisect run success
> ```
>
> Here's the steps if you want to try this locally:
>
> Save this script as `build/database-encoding-test` and `chmod +x`:
>
> ```
> #!/usr/bin/env bash
>
> main () {
> ./gradlew -Duser.country=de -D.user.language=DE -DreWriteBatchedInserts=true -Dautosave=always cleanTest postgresql:test --tests DatabaseEncodingTest
> }
>
> main "$@"
> ```
>
> Start the 9.1 server with:
>
> ```
> PGV=9.1 TZ=UTC XA=no SSL=no SCRAM=no CREATE_REPLICAS=no docker/bin/postgres-server
> ```
>
> Then starting at the HEAD of this PR (or any other "bad") commit:
>
> ```
> git bisect start
> git bisect bad
> git bisect good 79b784e3 # This is REL42.7.9
> git bisect run build/database-encoding-test
> ```
>
> That commit message in [3fab588](https://github.com/pgjdbc/pgjdbc/commit/3fab588d93ae4cfeb13f75ba08894b804b256d51) is deceiving as well. It's labeled `test: add autosave=... to the CI jobs` but it's actually making some changes to the `QueryExecutorImpl` as well. Still have to step through to understand why, but it's something in that commit that changed either when we're creating a save point or when we're cleaning them up.
>
> That combined with the lower defaults for 9.1 is causing this to fail over there for some specific combo of parameters.
I expect this is just the extra options in the test combined with the lower defaults in 9.1
@vlsi ?
view thread (42+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #3895: implement require_auth, this is pretty much how libpq does this.
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox