Message-ID: <gh-pgjdbc-pgjdbc-3895-rc2624499856@github.com>
From: "sehrope (@sehrope)" <noreply+sehrope@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 16 Dec 2025 19:35:26 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3895: implement require_auth, this is pretty much how libpq does this. 
In-Reply-To: <gh-pgjdbc-pgjdbc-3895-rc2624290166@github.com>
References: <gh-pgjdbc-pgjdbc-3895@github.com> <gh-pgjdbc-pgjdbc-3895-rc2624290166@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: sehrope
X-GitHub-Comment-Id: 2624499856
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: eebd8ea0fe770d05f2ad983798e10f41898f34a3
X-GitHub-Issue: 3895
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3895#discussion_r2624499856
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java)

Missed this before I wrote the other comment. Yes this whole thing would be easier to implement and understand with enums and sets. The parsing step becomes much easier too (just check if we've seen the value already for the dupe error).