Message-ID: <gh-pgjdbc-pgjdbc-3895-rc2624682297@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 16 Dec 2025 20:46:19 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3895: implement require_auth, this is pretty much how libpq does this. 
In-Reply-To: <gh-pgjdbc-pgjdbc-3895-rc2624614338@github.com>
References: <gh-pgjdbc-pgjdbc-3895@github.com> <gh-pgjdbc-pgjdbc-3895-rc2624614338@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 2624682297
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: bbd848a7d0c25438e055b0846bcbc3a0a6d79c58
X-GitHub-Issue: 3895
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3895#discussion_r2624682297
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java)

I changed fromString to throw an exception for unrecognized options