Message-ID: <gh-pgjdbc-pgjdbc-3895-rc2645778486@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 24 Dec 2025 14:20:20 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3895: implement require_auth, this is pretty much how libpq does this. 
In-Reply-To: <gh-pgjdbc-pgjdbc-3895@github.com>
References: <gh-pgjdbc-pgjdbc-3895@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2645778486
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: b72113255da1956e6c0323d4e8170d722f20629b
X-GitHub-Issue: 3895
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3895#discussion_r2645778486
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java)

```suggestion
    static void checkAuth(Set<AuthMethod> allowedMethods, AuthMethod authMethod) throws PSQLException {
```

`isAllowed(...)` results in repeated parsing, so why don't we parse the set once and pass it over the methods?

I'm not fond of `is...` methods that return void.