Message-ID: <gh-pgjdbc-pgjdbc-3895-rc2645969058@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Wed, 24 Dec 2025 15:55:24 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3895: implement require_auth, this is pretty much how libpq does this. 
In-Reply-To: <gh-pgjdbc-pgjdbc-3895-rc2645778486@github.com>
References: <gh-pgjdbc-pgjdbc-3895@github.com> <gh-pgjdbc-pgjdbc-3895-rc2645778486@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 2645969058
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: b72113255da1956e6c0323d4e8170d722f20629b
X-GitHub-Issue: 3895
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3895#discussion_r2645969058
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java)

AFAIUI `AUTH_REQ_OK` will only require a parse if it is simple password. Otherwise `pgStream.isFinishedAuthenticationRequests()` will be true and we don't call checkAuth. That said if you find it easier to reason, that's a good enough reason for me to change it