Message-ID: <gh-pgjdbc-pgjdbc-3895-rc2840839080@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 23 Feb 2026 13:21:29 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3895: implement require_auth, this is pretty much how libpq does this. 
In-Reply-To: <gh-pgjdbc-pgjdbc-3895@github.com>
References: <gh-pgjdbc-pgjdbc-3895@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 2840839080
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 13f1426fb9cbad5f6607368037a765ef92b3875e
X-GitHub-Issue: 3895
X-GitHub-Line: 840
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3895#discussion_r2840839080
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java:840)

Does it really mean `finished authentication requests`?
Can it be the case the backend issues SCRAM request after MD5?

If the only reason for this call is to track "have at least one auth request", we should consider renaming the property to something like "has auth requests", and we could set it like `if (authReq != AUTH_REQ_OK) { pgStream.hasAuthRequests(); }`