Message-ID: <gh-pgjdbc-pgjdbc-3917-rc2704972775@github.com>
From: "mjschwaiger (@mjschwaiger)" <noreply+mjschwaiger@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 19 Jan 2026 14:21:00 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #3917: test: add autosave=always|never|conservative and cleanupSavepoints=true|false to the randomized CI jobs
In-Reply-To: <gh-pgjdbc-pgjdbc-3917@github.com>
References: <gh-pgjdbc-pgjdbc-3917@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: mjschwaiger
X-GitHub-Comment-Id: 2704972775
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 53e5fb6398bdd2661d02919a9f5bd7284c22ee66
X-GitHub-Issue: 3917
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/3917#discussion_r2704972775
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java)

Wouldn't it be more efficient to test the main/default case of AutoSave.NEVER first, thereby avoiding these string comparisons inside `isSpecialQuery` most of the time?
```
if (getAutoSave() == AutoSave.NEVER) {
    return false;
}
if (isSpecialQuery(query)) {
    return false;
}
```